Skip to content

Add milestone and demilestoned triggers to pull request#29837

Merged
cmwilson21 merged 3 commits intogithub:mainfrom
Czaki:milestone_trigger
Nov 15, 2023
Merged

Add milestone and demilestoned triggers to pull request#29837
cmwilson21 merged 3 commits intogithub:mainfrom
Czaki:milestone_trigger

Conversation

@Czaki
Copy link
Copy Markdown
Contributor

@Czaki Czaki commented Nov 9, 2023 •
edited
Loading

Why:

During writing workflows, I have found that milestoned and demilestoned triggers are available for the pull request trigger groups. The suggestion for this I found in payload documentation https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=milestoned#pull_request

I have checked on my repository and this trigger works.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@welcome
Copy link
Copy Markdown

welcome Bot commented Nov 9, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

This was referenced Nov 9, 2023
Closed
Merged
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Nov 9, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 9, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/events-that-trigger-workflows.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7 3.6
ghae
 fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@CARTER2894

This comment was marked as spam.

Sign in to view
@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Nov 9, 2023

@Czaki Thanks for testing this and opening a PR with this update ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 9, 2023
SiaraMist
SiaraMist approved these changes Nov 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@SiaraMist SiaraMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this, @Czaki! Our repo is temporarily frozen, but I'm going to add the Merge after freeze label to your PR and it should get merged early next week. ⚡

@SiaraMist SiaraMist added ready to merge This pull request is ready to merge Merge-after-freeze and removed waiting for review Issue/PR is waiting for a writer's review labels Nov 9, 2023
Carreau pushed a commit to napari/napari that referenced this pull request Nov 14, 2023
@Czaki
Fix milestone and label checker to be triggered by milestoned/`demi…
e9d150f 
…lestoned` events (#6430)

See  #6288 (comment)

The milestoned, demilestoned events are not documented for the pull
request github/docs#29837, but works.

The issue events are not reported in the pull request status. This PR
should allow to use of any order of labeling and milestoning PR.
@cmwilson21 cmwilson21 enabled auto-merge November 15, 2023 19:58
@cmwilson21 cmwilson21 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into github:main with commit 64cc67b Nov 15, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 15, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@coderabbitai coderabbitai Bot mentioned this pull request Apr 27, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SiaraMist SiaraMist SiaraMist approved these changes

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Czaki @CARTER2894 @cmwilson21 @SiaraMist @docs-bot